fix gitversion to not recompute version from sdist by lucascolley · Pull Request #316 · Quansight-Labs/uarray

lucascolley · 2026-02-10T15:21:31Z

hopefully the last one needed @hameerabbasi 😅

lucascolley · 2026-02-10T15:29:08Z

lucascolley · 2026-02-10T15:32:06Z

Running command: /Users/lucascolley/ghq/github.com/scipy/scipy/.pixi/envs/build/bin/python3.14 /Users/lucascolley/ghq/github.com/scipy/scipy/subprojects/uarray/tools/gitversion.py
--- stdout ---

--- stderr ---
Traceback (most recent call last):
  File "/Users/lucascolley/ghq/github.com/scipy/scipy/subprojects/uarray/tools/gitversion.py", line 23, in <module>
    main()
    ~~~~^^
  File "/Users/lucascolley/ghq/github.com/scipy/scipy/subprojects/uarray/tools/gitversion.py", line 11, in main
    version_module = __import__(str(source_version_path))
ModuleNotFoundError: No module named '/Users/lucascolley/ghq/github'

lucascolley · 2026-02-10T15:33:16Z

looks like __import__ struggles if there is a . in the path

lucascolley

that doesn't help

Traceback (most recent call last):
  File "/Users/lucascolley/ghq/github.com/scipy/scipy/subprojects/uarray/tools/gitversion.py", line 23, in <module>
    main()
    ~~~~^^
  File "/Users/lucascolley/ghq/github.com/scipy/scipy/subprojects/uarray/tools/gitversion.py", line 11, in main
    version_module = __import__(str(source_version_path.absolute()))
ModuleNotFoundError: No module named '/Users/lucascolley/ghq/github'

lucascolley · 2026-02-10T15:38:33Z

perhaps

import importlib.util

spec = importlib.util.spec_from_file_location(
    "version_module",
    source_version_path,
)
module = importlib.util.module_from_spec(spec)
spec.loader.exec_module(module)

print(module.__version__)

hameerabbasi · 2026-02-10T15:42:59Z

perhaps

import importlib.util

spec = importlib.util.spec_from_file_location(
    "version_module",
    source_version_path,
)
module = importlib.util.module_from_spec(spec)
spec.loader.exec_module(module)

print(module.__version__)

That worked, thanks! I found the docs at about the same time as you! https://docs.python.org/3/library/importlib.html#importing-a-source-file-directly

hameerabbasi · 2026-02-10T15:44:57Z

Hmm, I was fairly sure that __import__ took paths, guess I was wrong.

Co-authored-by: Lucas Colley <lucas.colley8@gmail.com>

hameerabbasi · 2026-02-10T15:48:35Z

Imma merge this early to unblock you; wheels seem to be producing for all the platforms.

lucascolley · 2026-02-10T15:54:20Z

thanks Hameer :)

fix gitversion to not recompute version from sdist

bef7bf5

hameerabbasi reviewed Feb 10, 2026

View reviewed changes